Skip to content

Add ASYNC401 for pytest.raises(ExceptionGroup)#466

Merged
Zac-HD merged 2 commits into
python-trio:mainfrom
paranoa233:fix-pytest-raises-exceptiongroup-430
Jul 16, 2026
Merged

Add ASYNC401 for pytest.raises(ExceptionGroup)#466
Zac-HD merged 2 commits into
python-trio:mainfrom
paranoa233:fix-pytest-raises-exceptiongroup-430

Conversation

@paranoa233

Copy link
Copy Markdown
Contributor

Closes #430.

Summary

  • add opt-in ASYNC401 for pytest.raises(ExceptionGroup/BaseExceptionGroup)
  • detect direct, keyword, tuple, builtins-qualified, backport, and imported pytest.raises forms
  • document the new rule and add changelog coverage

Tests

  • python -m pytest tests/test_flake8_async.py -k ASYNC401
  • python -m pytest tests/test_messages_documented.py
  • python -m pytest tests/test_all_visitors_imported.py
  • python -m pytest --ignore=tests/test_config_and_args.py

@paranoa233
paranoa233 force-pushed the fix-pytest-raises-exceptiongroup-430 branch from 1c23490 to 4e4c1d1 Compare July 8, 2026 15:26
@jakkdl

jakkdl commented Jul 14, 2026

Copy link
Copy Markdown
Member

I'd lean towards default on

Comment thread flake8_async/visitors/visitor4xx.py Outdated
Comment thread docs/changelog.rst Outdated

@Zac-HD Zac-HD left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@Zac-HD
Zac-HD merged commit 7326ac7 into python-trio:main Jul 16, 2026
10 checks passed
@trio-bot

trio-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Hey @paranoa233, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lint rule for pytest.raises(ExceptionGroup)

3 participants